Comparison operations in nginx.conf.erb template look misplaced. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of comparison operations were being performed against the parameter of the call to scope.lookupvar instead of against the result of the call.
jfryman
added a commit
that referenced
this pull request
Oct 1, 2012
Comparison operations in nginx.conf.erb template look misplaced.
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Oct 23, 2017
Comparison operations in nginx.conf.erb template look misplaced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looked to me that a number of comparison operations that were being performed in the nginx.conf.erb template were misplaced? Comparisons were being performed against that parameter of the call to scope.lookupvar instead of against the result of the call.