Allow internal-only location resources #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Location resources with internal == true are valid, but the module does not allow them unless one or more of www_root, proxy, location_alias, stub_status, fastcgi, or location_custom_cfg are set This patch allows locations with none of those but internal == true to be created. This is a re-implementation of jfryman/nginx PR-388.
|
+1 |
|
@3flex this is the rebase you requested for PR-388 |
|
@jfryman please review and merge if you're happy with this, +1 from me. Just wondering if this might conflict with anything you had in the pipeline for vhost resources. |
jfryman
added a commit
that referenced
this pull request
Sep 25, 2014
Allow internal-only location resources
|
@danieldreier thanks so much for the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-implementation of #388 because it hasn't been rebased and I need the changes it makes.
Location resources with internal == true are valid in nginx, but the module does
not allow them unless one or more of www_root, proxy, location_alias,
stub_status, fastcgi, or location_custom_cfg are set
This patch allows locations with none of those but internal == true to
be created.