Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arrays values in http_cfg_append #527

Merged
merged 2 commits into from
Dec 11, 2014
Merged

Conversation

ese
Copy link
Contributor

@ese ese commented Dec 11, 2014

Allow arrays as values for variables that can be declared multiple times. For example:

nginx::http_cfg_append:
  set_real_ip_from:
    - "10.0.0.0/24"
    - "31.13.24.0/21"
    - "31.13.64.0/18"
    - "66.220.144.0/20"
    - "69.63.176.0/20"
    - "69.171.224.0/19"
    - "74.119.76.0/22"
    - "103.4.96.0/20"

result:

  set_real_ip_from 10.0.0.0/24;
  set_real_ip_from 31.13.24.0/21;
  set_real_ip_from 31.13.64.0/18;
  set_real_ip_from 66.220.144.0/20;
  set_real_ip_from 69.63.176.0/20;
  set_real_ip_from 69.171.224.0/19;
  set_real_ip_from 74.119.76.0/22;
  set_real_ip_from 103.4.96.0/20;

@jfryman
Copy link
Contributor

jfryman commented Dec 11, 2014

Nice! Can you include a test too?

@jfryman
Copy link
Contributor

jfryman commented Dec 11, 2014

💥

jfryman added a commit that referenced this pull request Dec 11, 2014
Allow arrays values in http_cfg_append
@jfryman jfryman merged commit 746a5bc into voxpupuli:master Dec 11, 2014
@jfryman
Copy link
Contributor

jfryman commented Dec 11, 2014

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants