more test and docs fixes for acceptance tests for CentOS / Passenger #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cegeka-jenkins
pushed a commit
to cegeka/puppet-nginx
that referenced
this pull request
Sep 13, 2019
…s_fixes_2 more test and docs fixes for acceptance tests for CentOS / Passenger
Rubueno
pushed a commit
to Rubueno/puppet-nginx
that referenced
this pull request
Oct 19, 2020
…s_fixes_2 more test and docs fixes for acceptance tests for CentOS / Passenger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@3flex @ffrank
Here's one more related to the now-merged #876
@3flex says that #885 should address the other test failure (though there will probably be a conflict if one isn't rebased after the other is merged).
I also added the
--fail(-f) option to curl for the vhost test calls that rely on exit status, which should return a non-zero exit code if there's a non-2XX response. Normally, curl will exit non-zero if there's a failure to connect in the first place, but if it connects and gets a 4XX or 5XX response, it will display the error but exit 0.Should figure out if we want to explicitly add some kind of dependency on epel or just document it as I've done in the README.