Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop EOL Debian 8 #425

Merged
merged 1 commit into from Sep 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .sync.yml
Expand Up @@ -7,7 +7,6 @@
- set: ubuntu2004-64
- set: centos7-64
- set: centos8-64
- set: debian8-64
- set: debian9-64
- set: debian10-64
spec/spec_helper.rb:
Expand Down
8 changes: 0 additions & 8 deletions .travis.yml
Expand Up @@ -59,14 +59,6 @@ jobs:
bundler_args: --without development release
env: BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_setfile=centos8-64 CHECK=beaker
services: docker
- rvm: 2.5.3
bundler_args: --without development release
env: BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_setfile=debian8-64 CHECK=beaker
services: docker
- rvm: 2.5.3
bundler_args: --without development release
env: BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_setfile=debian8-64 CHECK=beaker
services: docker
- rvm: 2.5.3
bundler_args: --without development release
env: BEAKER_PUPPET_COLLECTION=puppet5 BEAKER_setfile=debian9-64 CHECK=beaker
Expand Down
1 change: 0 additions & 1 deletion README.md
Expand Up @@ -490,7 +490,6 @@ the NodeSource URL structure - NodeSource might remove old versions (such as
The following are ``repo_url_suffix`` values that reflect NodeSource versions
that were available on 2017-11-29:

* Debian 8 (Jessie) ```0.10``` ```0.12``` ```4.x``` ```5.x``` ```6.x``` ```7.x``` ```8.x``` ```9.x```
* Debian 9 (Stretch) ```4.x``` ```6.x``` ```7.x``` ```8.x``` ```9.x```
* Debian (Sid) ```0.10``` ```0.12``` ```4.x``` ```5.x``` ```6.x``` ```7.x``` ```8.x``` ```9.x```
* Ubuntu 16.04 (Xenial) ```0.10``` ```0.12``` ```4.x``` ```5.x``` ```6.x``` ```7.x``` ```8.x``` ```9.x```
Expand Down
2 changes: 1 addition & 1 deletion manifests/params.pp
Expand Up @@ -21,7 +21,7 @@

case $facts['os']['family'] {
'Debian': {
if $facts['os']['release']['major'] =~ /^(8|9|10)$/ {
if $facts['os']['release']['major'] =~ /^(9|10)$/ {
$manage_package_repo = true
$nodejs_debug_package_name = 'nodejs-dbg'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look at https://packages.debian.org/stretch/nodejs-dbg then it looks like this package is not available on Buster, but npm is.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try to enable acceptance tests for Debian 10 to fix this now and in the future

$nodejs_dev_package_name = undef
Expand Down
1 change: 0 additions & 1 deletion metadata.json
Expand Up @@ -43,7 +43,6 @@
{
"operatingsystem": "Debian",
"operatingsystemrelease": [
"8",
"9",
"10"
]
Expand Down
2 changes: 1 addition & 1 deletion spec/classes/nodejs_spec.rb
Expand Up @@ -9,7 +9,7 @@
facts
end

is_supported_debian_version = if facts[:os]['family'] == 'Debian' && %w[8 9 10].include?(facts[:os]['release']['major'])
is_supported_debian_version = if facts[:os]['family'] == 'Debian' && %w[9 10].include?(facts[:os]['release']['major'])
true
else
false
Expand Down