only ensure real npm packages #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
commented
Oct 28, 2023
evgeni
force-pushed
the
fixup-npm-absent
branch
from
7ed7790
to
f627f19
Compare
bastelfreak
approved these changes
Oct 28, 2023
nodesource's `nodejs` packages have `Provides: npm` which means that when we try to `ensure => absent` the `npm` package, it really removes the `nodejs` package we want. by setting `allow_virtual => false` when using nodesource packages, we ensure that we only remove real packages. Fixes: 160ea93
evgeni
force-pushed
the
fixup-npm-absent
branch
from
f627f19
to
6c2c411
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodesource's
nodejspackages haveProvides: npmwhich means that when we try toensure => absentthenpmpackage, it really removes thenodejspackage we want.by setting
allow_virtual => falsewe ensure that we only remove real packages.Fixes: 160ea93
Pull Request (PR) description
This Pull Request (PR) fixes the following issues