Parameterize package names #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skpy i like this solution! would you mind squashing down the commits so we have no failing tests? |
This adds parameters for the following packages: * node_pkg * npm_pkg * dev_pkg For backwards-compatibility, I have left the `dev_package` boolean name intact. Added a little more documentation. Noted that this has been tested on Red Hat Enterprise Linux 6. Update tests: * Default to 'false' for `dev_package` on RHEL and derivatives (including Fedora and Amazon). * Add tests for RHEL and derivatives: * when `node_pkg` is defined * when `node_pkg` and `npm_pkg` are defined
|
Squashed, as requested! |
|
cool! now we just have to get somebody to merge it ;) |
|
Anything else I can do to push this along? |
|
@cmurphy can you cut a new release of this module? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds parameters for the following packages:
For backwards-compatibility, I have left the
dev_packageboolean name intact.Added a little more documentation.
Noted that this has been tested on Red Hat Enterprise Linux 6.
Note: this PR obviates #84