Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Reload rather than restart nscd #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Reload rather than restart nscd #56

wants to merge 2 commits into from

Conversation

traylenator
Copy link
Contributor

@traylenator traylenator commented Oct 17, 2019 •
edited

Pull Request (PR) description

On configuration change nscd should be reloaded and not restarted

  • /bin/systemctl reload nscd

will be called as appropriate.

@traylenator traylenator added the enhancement New feature or request label Oct 17, 2019
@traylenator traylenator changed the title Reload rather than restart nscd WIP: Reload rather than restart nscd Oct 17, 2019
@bastelfreak bastelfreak added the needs-work not ready to merge just yet label Oct 19, 2019
@vox-pupuli-tasks
Copy link

Dear @traylenator, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @traylenator, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @traylenator, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

bastelfreak
bastelfreak reviewed Dec 5, 2020
View reviewed changes
data/Ubuntu-16.04.yaml Outdated
@@ -0,0 +1,2 @@
---
nscd::service_restart: /usr/sbin/service nscd reload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this valid? I never saw a 16.04 without systemd and in all other modules we assume 16.04 and newer ubuntus are running with systemd

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/bin/systemctl just to be annoying.

bastelfreak
bastelfreak reviewed Dec 5, 2020
View reviewed changes
data/Debian-8.yaml Outdated
@@ -0,0 +1,2 @@
---
nscd::service_restart: /usr/sbin/service nscd reload
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that Debian 8 could be used with systemd and sysv, but in all other modules we have we assume it's running systemd. (also I think we should not support debian 8 anymore because it has very limited support and debian 9/10 are available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
enhancement New feature or request needs-work not ready to merge just yet tests-fail
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@traylenator @bastelfreak