Allow to configure more overlays #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce repetitions and fail hard when the overlay is unknown.
smortex
force-pushed
the
overlay-object-class
branch
2 times, most recently
from
24d42cc
to
bc0aafa
Compare
smortex
force-pushed
the
overlay-object-class
branch
from
bc0aafa
to
3c84125
Compare
smortex
changed the title
bastelfreak
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to configure an overlay unknown to the module, we end-up with broken configuration. In this case, a compilation failure is preferable.
Rework the code generation code to fail hard in such circumstances, and add some missing overlay configuration that we could not manage with the module previously.