Add EL9 support #375
Merged
Add EL9 support #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Apr 11, 2023
bastelfreak
reviewed
Apr 11, 2023
treydock
force-pushed
the
el9
branch
4 times, most recently
from
c11e4c4
to
524123e
Compare
bastelfreak
reviewed
Apr 12, 2023
lib/puppet/type/openldap_database.rb
Outdated
| @@ -56,6 +56,9 @@ | |||
| when 'RedHat' | |||
| if Facter.value(:operatingsystemmajrelease).to_i <= 6 | |||
| 'bdb' | |||
| # # TODO: Remove legacy fact when drop Puppet 6 support | |||
| elsif Facter.value('os.release.major').to_i >= 9 || Facter.value(:operatingsystemmajrelease).to_i >= 9 | |||
There was a problem hiding this comment.
Why add the legacy facy here at all? os.release.major is available in Puppet 6 as well.
There was a problem hiding this comment.
I tried, and it failed. https://github.com/voxpupuli/puppet-openldap/actions/runs/4669511461. I think using Facter.value to lookup the nested keys was not working for Puppet 6 for whatever reason. That actions all EL9 + Puppet 6 failed before I added the legacy fact back. They all failed because they still tried to use hdb.
There was a problem hiding this comment.
I think you can do Facter.value('os')['release']['major'] which should work on Puppet 6 and 7.
bastelfreak
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.