Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ubuntu 22.04 #376

Merged
merged 1 commit into from Apr 13, 2023
Merged

Support Ubuntu 22.04 #376

merged 1 commit into from Apr 13, 2023

Conversation

chrisongthb
Copy link
Contributor

Pull Request (PR) description

This PR adds support for Ubuntu jammy 22.04.

This Pull Request (PR) fixes the following issues

E: Package 'libldap-2.4-2' has no installation candidate
Error: /Stage[main]/Openldap::Client::Install/Package[libldap-2.4-2]/ensure: change from 'purged' to 'present' failed: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold install libldap-2.4-2' returned 100: Reading package lists...
Building dependency tree...
Reading state information...
Package libldap-2.4-2 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source
However the following packages replace it:
  libldap-common

E: Package 'libldap-2.4-2' has no installation candidate

@smortex smortex added the enhancement New feature or request label Apr 12, 2023
@smortex
Copy link
Member

smortex commented Apr 12, 2023

Looks good! Can you please combine your commits in a single one?

From your working directory:

git rebase -i origin/master # Interactively rewrite history

This will bring your editor listing all commits in your branch. Keep the first line unchanged, and replace pick with squash for all subsequent lines. Save and quit, your editor will pop again and allow you to combine all the commit messages in a single one.

Then push your updated branch:

git push -f            # Send the changes (-f is required because we re-wrote history)

@chrisongthb
Copy link
Contributor Author

Thx for the feedback - rebase done.

Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smortex smortex merged commit 821bfd1 into voxpupuli:master Apr 13, 2023
26 checks passed
@chrisongthb chrisongthb deleted the ubuntu_jammy branch April 14, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants