Relax validation of openldap_database's suffix parameter
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validation of the `suffix` parameter assumed conformance with RFC2247, but this is not a requirement and cause trouble to some users. A full validation of the suffix syntax to check if it conforms to RFC2253 is probably overkill, so for now, we just relax the used regexp to allow valid values which where previously rejected. Some valid DN syntax are still rejected, as supporting them would require to replace the regexp with a parser. Add them as known-bad examples in the test suite (pending tests). Fixes #391 Fixes #396
smortex
force-pushed
the
relax-dn-syntax
branch
from
ed25e9f
to
85772ef
Compare
|
@virus2500 can you please give this a try/review this PR? A "clean" fix is an unreasonable amount of work, but this quick fix should solve your issue 😉 |
|
@smortex Just tested it with an running install and an fresh install. Everything is working as expected. Thank you for your work :) |
|
Thanks! I'll ask for review in case somebody spot something wrong and will do a release soon. |
bastelfreak
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation of the
suffixparameter assumed conformance withRFC2247, but this is not a requirement and cause trouble to some users.
A full validation of the suffix syntax to check if it conforms to
RFC2253 is probably overkill, so for now, we just relax the used regexp
to allow valid values which where previously rejected.
Some valid DN syntax are still rejected, as supporting them would
require to replace the regexp with a parser. Add them as known-bad
examples in the test suite (pending tests).
Fixes #391
Fixes #396