Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repository handling #17

Merged

Conversation

crazymind1337
Copy link
Member

Pull Request (PR) description

Refactor repository handling to be able to use a specific package version.

This Pull Request (PR) fixes the following issues

Fixes #15

@crazymind1337 crazymind1337 marked this pull request as draft March 29, 2023 04:51
@crazymind1337 crazymind1337 added the enhancement New feature or request label Mar 29, 2023
@crazymind1337
Copy link
Member Author

crazymind1337 commented Mar 29, 2023

Build for CentOS 9 is failing due to https://forum.opensearch.org/t/packages-signed-with-sha-1-cannot-be-installed-or-upgraded-on-rhel9-systems/13677

Should we remove RHEL9 systems from testing or adjust the test to not use the repository for RHEL9 systems?

@crazymind1337 crazymind1337 marked this pull request as ready for review March 29, 2023 06:51
@smortex
Copy link
Member

smortex commented Mar 29, 2023

Should we remove RHEL9 systems from testing or adjust the test to not use the repository for RHEL9 systems?

Looks like EL9 is not supported by upstream yet, so I think the way of least resistance for now is to not add it to metadata.json. Intrepid people can still install it on EL-9 and be happy if the install method they choose work, but the CI will not kick in at this stage which is probably preferable.

@crazymind1337
Copy link
Member Author

I have removed CentOS 9 from metadata.

@crazymind1337 crazymind1337 merged commit 7a937bf into voxpupuli:master Mar 30, 2023
18 checks passed
@crazymind1337 crazymind1337 deleted the refactor-repository-handling branch March 30, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Using the repository will only install the current latest package version
2 participants