New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moves config management to config provider for X509 certificate; moves certificate from v1 to v3 #164
Conversation
…used cert.cnf.erb template
manifests/certificate/x509.pp
Outdated
@@ -125,8 +123,8 @@ | |||
Optional[String] $state = undef, | |||
Optional[String] $locality = undef, | |||
Optional[String] $unit = undef, | |||
Array $altnames = [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are you changing this? we try to use empty hashes/arrays as default values for them, instead of undef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, didnt know of this convention. i assumed it is discouraged like empty strings as default values. i will fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can check through https://voxpupuli.org/docs/reviewing_pr/ for our guidelines :)
Functionality
Due to: X.509 extensions included in the request are not copied by default. X.509 extensions to be added can be specified using the -extfile option.
Tests
changes tests to accomodate the above functionality changes
Issues
Fixes #158
Solves #100 and #101 due to obsolescence