Repair service management in Ubuntu 14.04 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This repairs Ubuntu 14.04, which is broken in the current git master state. The init-v script has no "status" command and is not idempotent, so puppet goes crazy and reintroduces bug #1
In 2015 this was repaired by 21cd8c1 (introducing service_pattern and setting it to vmtoolsd).
However it was changed again with 4e08426 (setting service_pattern to undef).
I don't know why Ubuntu 14 worked with a git state some commits earlier (because we used that), but i don't want to waste energy searching for it.
This PR reestablishes the service_pattern for Ubuntu 14.04. Newer ones rely on systemd for status.
This Pull Request (PR) fixes the following issues
#1 (was already fixed but came back alive)