Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate module to Voxpupuli #14

Closed
12 tasks done
ekohl opened this issue Feb 3, 2021 · 11 comments
Closed
12 tasks done

Migrate module to Voxpupuli #14

ekohl opened this issue Feb 3, 2021 · 11 comments

Comments

@ekohl
Copy link
Member

ekohl commented Feb 3, 2021

  • Ask one of the Administrators to add you to the incoming-migrations team.
  • At that point you can transfer your own repository.
  • If migrating a module from puppetlabs, re-enable github issues.
  • Verify that all webhooks except travis are disabled.
  • Update the README.md with a description of the deprecation and a link to the new module location.
  • Release a copy of your module to the ‘puppet’ forge account.
  • Add the module to our modulesync setup.
  • Ask an admin to add the collaborators team to the module’s Collaborators & Teams ‘Teams’ list with Write permissions (e.g. https://github.com/voxpupuli/puppet-gitlab/settings/collaboration)).
  • Execute modulesync for this module.
  • Create a Jira issue at https://tickets.puppetlabs.com and ask to deprecate the old module (and approve the new one if the old one was approved as well).
  • Ensure that there isn’t a CONTRIBUTING.md file in the docroot. Our modulesync will place one at .github/CONTRIBUTING.md. Please enhance our existing template if the version in the docroot contains useful parts.
  • Ensure that the module has a correct LICENSE file in the docroot that matches the mentioned license in the metadata.json.
@ekohl
Copy link
Member Author

ekohl commented Feb 3, 2021

voxpupuli/modulesync_config#700 & #15 should take care of most steps.

@raphink for the last point:
2275650 says it's GPL-3 in LICENSE
c398f4d says Apache-2.0 in metadata.json

Can you clarify which license is correct? I'm guessing GPL-3 since that's older.

@raphink
Copy link
Member

raphink commented Feb 3, 2021

Let's go with Apache-2.0, as that's what we've used for our modules usually.

@alexjfisher
Copy link
Member

Since most of the code is yours, @mcanevet can you confirm you're ok with Apache-2.0?

@mcanevet
Copy link
Member

mcanevet commented Feb 4, 2021

Yes, let's go with Apache-2.0

ekohl added a commit to ekohl/puppet-pbuilder that referenced this issue Feb 4, 2021
LICENSE said it was GPL-3. 2275650
which is the initial import included this.
In c398f4d metadata.json was added and
stated Apache-2.0.

In voxpupuli#14 it was decided
to license it as Apache 2.0.
@ekohl
Copy link
Member Author

ekohl commented Feb 4, 2021

#16 should fix the license.

@ekohl
Copy link
Member Author

ekohl commented Feb 8, 2021

This is pretty much done. In #17 I also remove some left over GPL copyright texts which were in the manifests. After that I'll see about releasing a new version so that the old one can be deprecated.

Note that the steps state the deprecation needs to happen via JIRA ticket but there's an API nowadays. We should come up with a curl example for it.

@ekohl ekohl mentioned this issue Sep 16, 2022
@ekohl
Copy link
Member Author

ekohl commented Sep 16, 2022

After that I'll see about releasing a new version so that the old one can be deprecated.

#23

@ekohl
Copy link
Member Author

ekohl commented Sep 16, 2022

It was finally released. @raphink I know you already left camptocamp, but do you still have access to run this? Or can you ask anyone with access?

curl -H 'Authorization: Bearer API_KEY' -X PATCH https://forceapi.puppet.com/v3/modules/camptocamp-builder -H 'Content-Type: application/json' -d '{"action": "deprecate", "params": {"reason": "Migrated to Vox Pupuli", "replacement_slug": "puppet-pbuilder"}}'

API_KEY can be retrieved from https://forge.puppet.com/

@raphink
Copy link
Member

raphink commented Sep 16, 2022

No, I don't have access to this secret @ekohl. Maybe @saimonn does for ex.

@ekohl
Copy link
Member Author

ekohl commented Sep 22, 2022

I opened https://tickets.puppetlabs.com/browse/FORGE-662 for now.

@ekohl
Copy link
Member Author

ekohl commented Oct 5, 2022

https://forge.puppet.com/modules/camptocamp/pbuilder now has a deprecation, meaning we can finally consider this completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants