Wrong merge behavior for settings, extensions, fpm_pools, fpm_global_pool_settings

[c33s]

currently the class parameters settings, extensions, fpm_pools, fpm_global_pool_settings are getting "double" looked up and merged.

because of puppets Automatic class parameter lookup, which already supports the lookup behaviors first, unique, hash or deep, it comes to an unexpected behavior if the lookup_option in the hiera file is anything else than deep (first is the default)

https://puppet.com/docs/puppet/5.3/hiera_automatic.html
https://puppet.com/docs/puppet/5.0/hiera_merging.html

common.yaml

lookup_options:
    php::extensions: { merge: {strategy: first} }

php::extensions:
  bcmath: {}

my.example.com.yaml

php::extensions:
  soap: {}

should result in { soap } on my.example.com but because of this bug, it results in { soap, bcmath }

the following code snippet where deep is hardcoded, is responsible for this bug.
init.pp

  # Deep merge global php settings
  $real_settings = deep_merge($settings, lookup('php::settings', {value_type => Hash, merge => 'deep', default_value => {}}))

  # Deep merge global php extensions
  $real_extensions = deep_merge($extensions, lookup('php::extensions', {value_type => Hash, merge => 'deep', default_value => {}}))

  # Deep merge fpm_pools
  $real_fpm_pools = deep_merge($fpm_pools, lookup('php::fpm_pools', {value_type => Hash, merge => 'deep', default_value => {}}))

  # Deep merge fpm_global_pool_settings
  $real_fpm_global_pool_settings = deep_merge($fpm_global_pool_settings, lookup('php::fpm_global_pool_settings', {value_type => Hash, merge => 'deep', default_value => {}}))

[c33s]

fixed via #435