Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect $manage_repos, do not include ::apt if set to false #278

Merged
merged 1 commit into from
Dec 29, 2016
Merged

respect $manage_repos, do not include ::apt if set to false #278

merged 1 commit into from
Dec 29, 2016

Conversation

fraenki
Copy link
Member

@fraenki fraenki commented Dec 6, 2016

PR #250 introduced code that unconditionally includes ::apt. This should be changed to respect wether $manage_repos is actually set to true or not.

Otherwise I'm unable to use my own repo management, because the include leads to a duplicate declaration:

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Class[Apt] is already declared

@dhoppe
Copy link
Member

dhoppe commented Dec 29, 2016

@fraenki Thank you very much for your contribution.

@dhoppe dhoppe merged commit 4c1223a into voxpupuli:master Dec 29, 2016
@joshuaspence
Copy link
Contributor

Sorry, I commented on the commit without seeing the corresponding pull request. I'll fix a PR.

@roll4life
Copy link

roll4life commented Mar 22, 2017

@joshuaspence tested your fix on ubuntu 16.04, and it does resolve the issue with php7.0-cli, but if you have dev => true or pear => true it throws Error: Could not find dependency Class[Apt::Update] for Package[php7.0-xml] this is important because pear is required for pecl, which on ubuntu is necessary for php-redis, php-memcached etc . . . since those packages do not adhere to the php7.0 prefix

@joshuaspence
Copy link
Contributor

When you say that you tested my fix, did you mean #323?

@roll4life
Copy link

Yes, that is correct. Sorry I should have specified.

@joshuaspence
Copy link
Contributor

Right, okay. I think that problem isn't caused by my pull request though. It seems like an existing issue.

@roll4life
Copy link

correct. That is an issue of include ::apt missing from manifests/dev.pp and manifests/pear.pp
at least in puppet 3. I can create a separate issue if needed.

rodricels pushed a commit to rodricels/puppet-php that referenced this pull request Jan 31, 2018
…`true`

The change introduced in voxpupuli#278 seems reasonable, but it means that `Class['apt::update']` may not actually be defined.
motivator pushed a commit to bigcommerce/puppet-php that referenced this pull request Oct 5, 2020
…`true`

The change introduced in voxpupuli#278 seems reasonable, but it means that `Class['apt::update']` may not actually be defined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants