Skip management of MySQL PHP module .ini file if using Ubuntu and repo #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure about these travis-ci errors: should contain Package[php5-json] (FAILED - 1) |
tdm4
changed the title
added 3 commits
March 16, 2017 16:38
…be consistent with rest of class
Only skip managing the .ini files if it is the mysql extension Correctly use $name and check for mysql Remove mysql.ini if it exists on PHP 7.0 or 7.1 modulesync 0.20.1 Change $::lsbdistid to $::operatingsystem to fix rake spec error and be consistent with rest of class
…et-php into Fix_MySQL_module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ondřej Surý PHP repo automatically configures the module .ini files. There is no need for php::extension::config to do anything. PR #322 only applies this to the mysql module, but, the PHP .deb packages already configure their modules in post-install.