expose fpm user and group #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add doc and tests? Sounds important in this PR. |
|
Sorry, rubocop is not happy yet :( |
roidelapluie
requested changes
Mar 16, 2017
spec/classes/php_spec.rb
Outdated
| let(:params) { { fpm_user: 'nginx' } } | ||
| it { is_expected.to contain_class('php::fpm').with(user: 'nginx') } | ||
| it { is_expected.to contain_php__fpm__pool('www').with(user: 'nginx') } | ||
| # rubocop:disable RSpec/RepeatedExample |
There was a problem hiding this comment.
maybe you could instead do:
dstfile = case facts[:operatingsystem]
when 'Ubuntu'
'/etc/php5/fpm/pool.d/www.conf'
when 'os2'
'.etc//c/c/c/c/'
end
it { is_expected.to contain_file(dstfile).with_content(/user = nginx/) }
|
Thank you! |
motivator
pushed a commit
to bigcommerce/puppet-php
that referenced
this pull request
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
The fpm user and group are not currently overridable outside of Hiera. This propagates the fpm user and group similarly to log_owner and log_group.
Redhat systems default the user to apache, but we're using nginx.
Let me know if this needs anything else. Thanks!