Bug/duplicate extension includes #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
added
needs-tests
backwards-incompatible
bug
|
Hi @samueljamesmarshall, thanks for the PR. Can you please extend our acceptance tests on https://github.com/voxpupuli/puppet-php/tree/master/spec/acceptance to verify that this patch works? |
|
Hi @samueljamesmarshall. Any update on this? |
|
@bastelfreak could you provide some guidance on how to implement the tests needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Solving duplicate extension includes for extensions installed via the system package manager. This resolves breaking PHP warnings.
This Pull Request (PR) fixes the following issues
Fixes #391
Relates to #333