Problem when installing the same package with PECL and APT

[leopoiroux]

Pull Request (PR) description

If you want to install a package with PECL and APT on the same node (ex: memcached), an error appears because Package["memcached"] is already defined. By prefixing the class name and specifying the "name" key, this problem is solved.

This Pull Request (PR) fixes the following issues

Fixes #320

[bastelfreak]

Hi @leopoiroux , thanks for the fix. Can you please write a unit or acceptance test for this change?

[leopoiroux]

Yes !!! All checks have passed ;)

[bastelfreak]

Can you please add an acceptance test that installs a package via APT + one via PECL? The current tests are located at https://github.com/voxpupuli/puppet-php/tree/master/spec/acceptance. You can ping us always in our IRC channel #voxpupuli on freenode or at https://puppetcommunity.slack.com if you have any questions.

[leopoiroux]

I don't know how to do that. I'm sorry.

[bastelfreak]

Do you have an example for the php::extension defined resource that installs a PECL package and one for APT? If so, I can throw it together into an acceptance tests.

[bastelfreak]

Hey @leopoiroux, any update on this?

[leopoiroux]

Hello,
I'm sorry but I don't know how to do an acceptance test.

My example is the installation of the "memcached" extension via PECL and the installation of the "memcached" package via APT.

Without my patch the class Package['memcached'] is already used by your class.
With my patch, I prefix your class with "phpmod_" and so no more conflict problems.

Currently, I had to trick my APT installation like this. But I shouldn't have to bypass this conflict.

class { '::php':
      extensions => {
            memcached => {
                provider => 'pecl',
                header_packages => ['libmemcached-dev'],
            },
      }
}

package { 'apt_memcached':
        name => 'memcached',
        ensure => 'present';
}

Thank you for your help.

[jonhattan]

Duplicate of #320

[Dan33l]

Hi @leopoiroux , to be able to produce acceptance tests, the first step is to consider your are writing puppet code with your PR embedded in used module. And so, what is the working puppet code to use when we want to install a same php extension by apt and PERC ? Can you provide this peace of puppet code ?

Fill free to join us on IRC or Slack #voxpupuli channel. We can provide some guidance.

[pccibot]

Dear @leopoiroux, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[pccibot]

Dear @leopoiroux, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

[Dan33l]

@leopoiroux @jonhattan this PR is not a duplicate.
The pointed #320 is an issue.

Feel free to reopen the PR to be able to continue the fix of issue.