Rely more on puppetlabs-apt #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the code to rely more on puppetlabs-apt features. It passes in the key and lets apt::source define apt::key for us. Puppetlabs-apt also knows better when apt-transport-https is actually needed. On the most recent Debian/Ubuntu releases it doesn't even exist anymore since apt handles it out of the box. It also removes the absolute resource notation which is no longer needed.
|
@RedChops would you be able to test and verify this works for you? |
|
@ekohl I just implemented the patch and it seems to have applied nicely without a change on my nodes! |
|
Thanks for testing @RedChops! I've marked it as enhancement because strictly speaking we do change the behavior a bit. By passing $key in directly it's possible to directly change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the code to rely more on puppetlabs-apt features. It passes in the key and lets apt::source define apt::key for us.
Puppetlabs-apt also knows better when apt-transport-https is actually needed. On the most recent Debian/Ubuntu releases it doesn't even exist anymore since apt handles it out of the box.
It also removes the absolute resource notation which is no longer needed.