Fix php::fpm eternal reload for mysqli a simplexml extension

[miranovy]

Pull Request (PR) description

Fix eternal reload for mysqli and simplexml extension.

Package name for mysqli extension is php7.2-mysql. Package name for simlexml extension is php7.2-xml. I can use package_prefix variable, than i add package_name variable with higher priority.

Example of configuration:

class { '::php':
        ensure       => latest,
        manage_repos => false,
        pear         => true,
        composer     => false,
        fpm          => false,
        dev          => false,
        extensions   => {
            bcmath    => {},
            curl      => {},
            gd        => {},
            mbstring  => {},
            simplexml => {
                package_name => 'php7.2-xml',
            },
            mysqli    => {
                package_name => 'php7.2-mysql',
            },
            sqlite3   => {},
        },
    }

This Pull Request (PR) fixes the following issues

Fixes #309
Fixes #497

[bastelfreak]

Hi @miranovy, thank for the bugfix. Can you add an acceptance test for this? We have some examples in https://github.com/voxpupuli/puppet-php/tree/master/spec/acceptance. Let us know if you need some help! We're available in our IRC channel #voxpupuli on freenode and at slack https://slack.puppet.com

[miranovy]

Hi @bastelfreak, you mean something like that in phpspec.rb:

...

 case default[:platform]
    when %r{ubuntu-18.04}
      packagename = 'php7.2-fpm'
      simplexmlpackagename = 'php7.2-xml'
    when %r{ubuntu-16.04}
      packagename = 'php7.0-fpm'
      simplexmlpackagename = 'php7.0-xml'
    when %r{ubuntu-14.04}
      packagename = 'php5-fpm'
      simplexmlpackagename = 'php5-xml'
    when %r{el}
      packagename = 'php-fpm'
    when %r{debian-8}
      packagename = 'php5-fpm'
    when %r{debian-9}
      packagename = 'php7.0-fpm'
    end
    describe package(packagename) do
      it { is_expected.to be_installed }
    end

    describe service(packagename) do
      it { is_expected.to be_running }
      it { is_expected.to be_enabled }
    end
  end
  context 'default parameters with extensions' do
    case default[:platform]
    when %r{ubuntu-18.04}, %r{ubuntu-16.04}, %r{ubuntu-14.04}
      it 'works with defaults' do
        pp = <<-EOS
        class{'php':
          extensions => {
            'mysql'    => {},
            'gd'       => {},
            'net-url'  => {
              package_prefix => 'php-',
              settings       => {
                extension => undef
              },
            'simplexml'  => {
              package_name => simplexmlpackagename
            }
          }
        }
        EOS
        # Run it twice and test for idempotency
        apply_manifest(pp, catch_failures: true)
        apply_manifest(pp, catch_changes: true)
      end
    else
      it 'works with defaults' do
        pp = <<-EOS
        class{'php':
          extensions => {
            'mysql'    => {},
            'gd'       => {}
          }
        }
        EOS
        # Run it twice and test for idempotency
        apply_manifest(pp, catch_failures: true)
        apply_manifest(pp, catch_changes: true)
      end
    end
...

[bastelfreak]

Hi,
yes that looks good.

[bastelfreak]

@miranovy can you take a look at the failed travis jobs ?

[bastelfreak]

Can you take a look at the failing travis jobs?

[miranovy]

Can you take a look at the failing travis jobs?

There was duplicity with default xml package for ubuntu (file manifests/dev.pp:47). Still to solve dependence on ubuntu 1404.

[bastelfreak]

Thanks!

[miranovy]

Thanks!

You're welcome. Thank you for merge.