set default version for debian buster and add support for buster #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debian buster was released on july 6th and many folks are already deploying it. This module should start supporting the new debian stable version. For this, we need the module to know what the new default PHP version is for this new release. Closes: voxpupuli#529
metadata.json currently specifies that only debian version 8, 9 and 10 are supported, so this version comparison will always result to false.
|
my last comment fixed the checks but travis is buggy and a bunch of checks timed out (hence the errors that show up). I don't know how to relauch the jobs that errored out |
|
This time most of the workers completed their jobs but two of them got networking issues >.< |
dhollinger
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debian buster was released on july 6th and many folks are already
deploying it. This module should start supporting the new debian stable
version.
For this, we need the module to know what the new default PHP version is
for this new release.
Closes: #529
Pull Request (PR) description
This Pull Request (PR) fixes the following issues