fix "cannot redefine $real_settings" error #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to use the apache_config class to apply settings to the apache SAPI fails with an error caused by a duplicate variable definition: Error while evaluating a Resource Statement, Evaluation Error: Cannot reassign variable '$real_settings' (file: /etc/puppetlabs/code/environments/development/modules/php/manifests/apache_config.pp, line: 18, column: 18)
|
This looks sane to me. Definitely a syntax error caused by the previous change to this file in #522 This manifest could use some tests though to prevent this from happening again. I'm going to merge this anyway though as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Trying to use the apache_config class to apply settings to the apache
SAPI fails with an error caused by a duplicate variable definition:
This Pull Request (PR) fixes the following issues