Improve package prefix selection on FreeBSD #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests would help this get merged or someone else verifying this works with FreeBSD 9-11. |
|
@oxc please rebase against our latest master branch. |
As of 2018-03-08, pear is flavored/prefixed in FreeBSD[1]. Remove the special handling and use the configured prefix as for most other distributions. [1] See UPDATING note e.g. on https://www.freshports.org/devel/pear/
If the php version has been set in globals, use it to determine the default package prefix on FreeBSD. This should be a compatible change, since the package prefix can still be overridden, and has to match the selected version anyway.
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On FreeBSD, the package prefix is currently hardcoded to php56. This change modifies the default behaviour to use the prefix matching the selected php version (from globals) if defined.
This change should be fully compatible, since the default is to fallback to php56, and if a custom version is specified, the package prefix has to be manually configured to match this version anyway.
Futhermore, the pear package is now using a php prefix as well (since 2018-03-08), which is also fixed by this pull request.