Allow sury repo for PHP >= 7.1. #555
Conversation
Hexta
force-pushed
the
fix_debian_packages
branch
from
cb3c27d
to
0440063
Compare
|
Could anybody please take a look at the PR? |
| @@ -67,7 +67,13 @@ | |||
| } | |||
| } | |||
|
|
|||
| if ($sury and $php::globals::php_version in ['5.6','7.1','7.2'] ) { | |||
There was a problem hiding this comment.
would be better to simply add the supported php version of sury in the array, only this way non valid php versions could be catched.
with your change a php version like 8.0 would be allowed
There was a problem hiding this comment.
Do you really think that hardcoded list of supported php versions is a good idea?
There was a problem hiding this comment.
not really, i prefer to have them configureable via hiera with sane default values directly set in this module with hiera. i would prefer that for many hardcoded values (like the repo key id) but without a bigger refactoring this is not possible.
to simply remove the version check feels wrong to me.
|
@Hexta please rebase against our latest master branch. |
Hexta
force-pushed
the
fix_debian_packages
branch
from
0440063
to
4bc4875
Compare
Hexta
force-pushed
the
fix_debian_packages
branch
from
4bc4875
to
88aa723
Compare
Hexta
force-pushed
the
fix_debian_packages
branch
from
88aa723
to
5a6561f
Compare
|
Dear @Hexta, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Pull Request (PR) description
Allow sury repo for PHP >= 7.1.
This Pull Request (PR) fixes the following issues