New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable management of rundir #674
Conversation
Why are we managing this directory if it's not used? Maybe there is a better solution here, like making it conditional on some version of package or OS? |
We are using /var/run/ and i wouldn't manage this directory with the puppet-php module. |
It there no way to merge this MR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK to me. We'll want to rebase when merging this to eliminate the merge commit.
@kenyon i removed the merge commit |
@smortex i added the documentation |
@smortex is everything fine? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feel weird, but I don't know what this directory is used for and the default behavior is unchanged so LGTM 🤷.
CI failure seems unrelated, merging |
I am using php7.4 from sury on debian 10.
After every server reboot, this module creates the
/var/run/php-fpm
directory (which is not used by php-fpm) and triggers a reload, which resets all open connections to the php-fpm daemon.This PR added an option to disable the managing of the
/var/run/php-fpm
directory