Add support for Debian 12 (bookworm)

[jcharaoui]

Pull Request (PR) description

Not much is changed for PHP in this upcoming release, except for the version of PHP shipped which is now 8.2

[jcharaoui]

Debian 12 bookworm has been released over 3 months ago.

[smortex]

This is currently blocked by the absence of Debian 12 packages for Puppet.

When packages are available, CI will be able to run the test suite on Debian 12, and we will be able to merge this. Thanks

[jcharaoui]

This is currently blocked by the absence of Debian 12 packages for Puppet.

Puppet packages are indeed available for Debian 12: https://packages.debian.org/bookworm/puppet-agent

[smortex]

I am speaking about the AIO Puppet Agent package from Puppetlabs/Perforce.

[BuJo]

Just here to confirm that the branch works very well on Debian 12.

[jcharaoui]

Other modules such as the postgresql Puppetlabs module have merged Debian 12 support some time ago already. It's really unfortunate that the AIO package delay is blocking this.

I understand the need for testing and CI but in this case the changeset is very small and we have multiple confirmations that it works.

[kenyon]

@jcharaoui Last night I rebased this on the current master branch. There are actual test failures that need to be addressed due to what appears to be differences in Debian 12.

[ftrojahn]

In https://github.com/voxpupuli/puppet-php/blob/master/manifests/repo/debian.pp#L53
shouldn't there be another ,'12' added in this line, too?
At least this was needed to add the sury repo in bookworm successfully.

[kenyon]

@ftrojahn yes, plus an update to the tests that came in a9ca033. Or better, just change those version checks to less-than and greater-than comparisons so that we don't have to keep updating them.

[jcharaoui]

I updated the specs, relevant tests now green!

[joec4i]

Hi @kenyon Can we cut a release to include this? 🙏