Fixes ACL's with spaces

[i1tech]

Fix for ACL's with spaces, which otherwise cause ACL's to be applied with every puppet agent run.

[dobbymoodge]

@i1tech Sorry for the slow response, can you update the tests to cover this functionality?

[dobbymoodge]

Also, when can ACLs have spaces in them?

[i1tech]

Spaces in ACL's are common when Auth'ing against an Active Directory Domain controller, especially in the case of Groups. (ie "Domain Adminsitrators", "Service Accounts", etc) Depending on how the Linux side is setup, using SSS, LDAP, NSLCD+LDAP, Winbind, LikewiseOpen, Centrify, etc. you will also find spaces embedded in the username. I'll try to find some time to work on the tests.

[dobbymoodge]

@i1tech Also, please rebase so Travis stops whining about Ruby 1.8.7. :D

[roidelapluie]

@dobbymoodge you have push access to the repo .. that is a new github feature

[dobbymoodge]

@roidelapluie ah, so I do. Now I understand what you were going on about. ☺️

[dobbymoodge]

@roidelapluie @i1tech I added a test, but I'm not sure I did it the Right Way. In particular, I wonder if I should be able to stub out the 2 methods without pulling in RSpec::Mocks. Thoughts?

[i1tech]

Thanks for adding that test, it would probably have been a while before I was able to get to it. Seem very busy these days.

[dobbymoodge]

@i1tech You've actually tested this in an environment with spaces in the group/usernames?

[dobbymoodge]

Waiting for feedback from @roidelapluie on the quality of this test before I merge. :)

[i1tech]

Absolutely, we are running the patched version of the module on our Puppet4 server.

[dobbymoodge]

I'll go ahead and merge then, and we can fix the test later if needed.