Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change filename to allow rendering on Puppet Forge. #60

Merged
merged 3 commits into from
May 11, 2019

Conversation

cdchase
Copy link

@cdchase cdchase commented May 1, 2019

Pull Request (PR) description

Rendering of README on Puppet Forge is broken due to the filename.
This PR changes the filename to match the more common use: README.md

@dhoppe
Copy link
Member

dhoppe commented May 1, 2019

It is not enough to rename the file, because the syntax is not Markdown.

@cdchase
Copy link
Author

cdchase commented May 1, 2019

Oops. GitHub was doing such a good job rendering it, I didn't even notice! I updated syntax and standardized per PDK template.

Still could use a 'Reference' section and some details.

@cdchase
Copy link
Author

cdchase commented May 1, 2019

@dhoppe do you know what that syntax was? It was clearly another type of markup, but I did a little research and could not identify. Wondered if there might be a conversion script around...

README.md Outdated
'group:webadmin:rwx',
'user:apache:rwx',
],
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the indentation.

@dhoppe
Copy link
Member

dhoppe commented May 1, 2019

@cdchase Sorry, I have no idea which kind of syntax that is. Did you check, if this module is compatible to puppet-strings? We already have a rake task, which will generate a REFERENCE.md.

@cdchase
Copy link
Author

cdchase commented May 1, 2019

I did not check anything further in this module. puppet-strings is new to me, so thanks for pointing it out. I was only intending on helping to get this visible from Puppet Forge.

@cdchase
Copy link
Author

cdchase commented May 1, 2019

Fixes #55

@bastelfreak bastelfreak merged commit c74e6f0 into voxpupuli:master May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants