X bit support #61
Merged
X bit support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[ps hold tight on accepting this, dealing with rubocop complaints and such -- going to condense the commits once i finish resolving it] |
|
Ok we should be good! |
bastelfreak
reviewed
Jun 17, 2019
| @@ -1,5 +1,6 @@ | |||
| require 'set' | |||
| require 'pathname' | |||
| require 'English' | |||
There was a problem hiding this comment.
And really the only reason I switched from $~ to $LAST_MATCH_INFO because rubocop yelled at me and questioned my lineage. ^_^
bastelfreak
added
enhancement
ekohl
reviewed
Jun 17, 2019
| @@ -1,5 +1,6 @@ | |||
| require 'set' | |||
| require 'pathname' | |||
| require 'English' | |||
lib/puppet/type/posix_acl.rb
Outdated
| def set_insync(cur_perm) # rubocop:disable Style/AccessorMethodName | ||
| should = @should.uniq.sort | ||
| should = @should.uniq.map(&:downcase).sort |
There was a problem hiding this comment.
perhaps better to first downcase and then uniq
There was a problem hiding this comment.
Excellent catch =D Changed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This pull request includes a fix that @pyslarvt made to add rwX style settings that didn't appear to make it into a formal PR. The fix as-is would frequently leave my hosts updating on every Puppet run. The modifications I made add in support for properly comparison the current permissions set, even if you have the capital X bit set. (note: X is only for setfacl, it's not a "real" posix acl, so you have to lowercase it to do comparisons) This was already handled in the :unset handler, but not in set or exact. Note it is possible that I've missed a few use cases as I don't really use anything but the set action.
I may follow this PR by writing up a quick README as well, depends on what time I have to spare. =)
This Pull Request (PR) fixes the following issues
Fixes #9