fix comparing permissions when they have a mix of upper- and lower-ca… #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unki
force-pushed
the
fix-case-sensitivity
branch
from
9263b25
to
1925f30
Compare
|
thanks for the bugfix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. on Debian there is a user
Debian-exim- with an upper-caseD.Since the
v1.0.0release this has led puppet-posix_acl think the permission property is all the time out-of-sync, as the module was comparing e.g.u:Debian-exim:r--againstu:debian-exim:r--at certain places.This PR fixes it for me - but I'm not sure if I have covered all the edge-cases.