init.pp: correct param numbers and use of optional #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyon
force-pushed
the
fix-param-numbers-and-optional-usage
branch
from
1b1febb
to
aa6f9e3
Compare
Parameters used for generating resources should be plural. Remove incorrect usage of Optional. Also, use loops instead of `create_resources()`.
kenyon
force-pushed
the
fix-param-numbers-and-optional-usage
branch
from
aa6f9e3
to
5608bb6
Compare
smortex
approved these changes
Oct 18, 2021
|
@smortex this shouldn't be labeled backwards-incompatible because we haven't made a release since the parameters were added, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parameters used for generating resources should be plural.
Remove incorrect usage of
Optional.Also, use loops instead of
create_resources().This is not a backwards-incompatible change because we haven't made a release since these parameters were added.