support for multiple portstrees #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| exec { "poudriere-jail-${jail}": | ||
| command => "/usr/local/bin/poudriere jail -d -j ${jail}", | ||
| onlyif => "/usr/local/bin/poudriere jail -l | grep -w '^${jail}'", |
There was a problem hiding this comment.
Could you please fully qualify the grep here?
|
Although I normally would rather solve the path issue with an path param, since this module is specifically for FreeBSD, I'm cool with hardcoding it! |
zachfi
pushed a commit
that referenced
this pull request
Jul 11, 2014
support for multiple portstrees
|
Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was working on multiple portstrees to build custom ports, I figured I should add support for it in puppet-poudriere. I kept some backward compatibility in init.pp but that could be removed later on.
While on it, I added 'ensure' parameters to both poudriere::env and poudriere::portstree so they can be removed later on.