Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor nitpick #1

Closed
tarjei opened this issue Apr 10, 2016 · 7 comments
Closed

Minor nitpick #1

tarjei opened this issue Apr 10, 2016 · 7 comments

Comments

@tarjei
Copy link
Contributor

tarjei commented Apr 10, 2016

Hi I would like to suggest that the example config also includes config for a local node_exporter :)

Also - thanks for making this module!

@brutus333
Copy link
Collaborator

Sure, I am going to change it with the next release. I am planning to add support for push gateway, too.
Stay tuned.

@tarjei
Copy link
Contributor Author

tarjei commented Apr 12, 2016

Great, thanks :)

2016-04-12 11:42 GMT+02:00 brutus333 notifications@github.com:

Sure, I am going to change it with the next release. I am planning to add
support for push gateway, too.
Stay tuned.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#1 (comment)


Tarjei Huse
Mobil: 920 63 413

@William1444
Copy link

Hi there! This module has saved us a tonne of time!
Have you had any chance to look at push gateway support? I am looking at this myself now, and think I'll need to do it manually for now.

@brutus333
Copy link
Collaborator

I reached a point when I would like to find some spare time to develop a special module for generic startup scripts templates based on defined resources. Otherwise, the code grows ugly and it is hard to be maintained....

lswith pushed a commit to lswith/puppet-prometheus that referenced this issue Jan 20, 2017
roidelapluie pushed a commit that referenced this issue Jun 21, 2017
Add service_name parameter for alertmanager
@TheMeier
Copy link
Contributor

i think the original issue of providing node_exporter configuration is sufficiently adressed...

@juniorsysadmin
Copy link
Member

Resolved by a1a6481

@tarjei
Copy link
Contributor Author

tarjei commented Oct 19, 2017

Thanks!

mdebruyn-trip pushed a commit to mdebruyn-trip/puppet-prometheus that referenced this issue Nov 4, 2017
robmbrooks pushed a commit to robmbrooks/puppet-prometheus that referenced this issue Mar 21, 2020
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
…ce_name

Add service_name parameter for alertmanager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants