Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toplevel parameter init_style ignored #629

Closed
LionelCons opened this issue Aug 2, 2022 · 0 comments · Fixed by #642
Closed

Toplevel parameter init_style ignored #629

LionelCons opened this issue Aug 2, 2022 · 0 comments · Fixed by #642
Labels
good first issue Good for newcomers

Comments

@LionelCons
Copy link

LionelCons commented Aug 2, 2022 •
edited
Loading

The init_style parameter given to the prometheus class is ignored.

This is because it is used in the prometheus::server class and, in this class, it defaults to $facts['service_provider'] and not $prometheus::init_style.

See:
https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/init.pp#L301
https://github.com/voxpupuli/puppet-prometheus/blob/master/manifests/server.pp#L36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace $facts['service_provider'] by $prometheus::init_style (except init.pp)
2 participants
@smortex @LionelCons