Feature/alerts prometheus2 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhooyberghs
force-pushed
the
feature/alerts_prometheus2
branch
from
bbf2792
to
deb8216
Compare
|
Hi @jhooyberghs, thanks for the PR. Are you able to add an acceptance test that installs prometheus 2 with the new hash? |
vStone
force-pushed
the
feature/alerts_prometheus2
branch
from
695cc33
to
5206ab7
Compare
vStone
force-pushed
the
feature/alerts_prometheus2
branch
from
5206ab7
to
e9fddd1
Compare
|
@bastelfreak: Since the acceptance tests are minimal in general, I've just added spec tests. |
|
@bastelfreak are these spec tests sufficient? |
|
Thanks for the PR @jhooyberghs ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Feature/alerts prometheus2
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Feature/alerts prometheus2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds alerts to prometheus 2.0 . I wrote this code because I ran into the same problem as issue #120
This code should be backwards compatible, leaving all < 2.0 installations with the old epp template, and all newer prometheus installations can now use a yaml configuration hash, which gets converted to a YAML configuration file as needed according to the documentation (https://prometheus.io/docs/prometheus/2.0/migration/#recording-rules-and-alerts)