Add custom datasource possibilities for postgres_exporter #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jan 14, 2019
manifests/postgres_exporter.pp
Outdated
| String[1] $arch = $prometheus::real_arch, | ||
| String[1] $bin_dir = $prometheus::bin_dir, | ||
| Enum['custom', 'env', 'file'] $postgres_auth_method, | ||
| Hash[String,String] $data_source_custom = {}, |
There was a problem hiding this comment.
Can you please enforce the minimal string length?
Suggested change
| Hash[String,String] $data_source_custom = {}, | |
| Hash[String[1],String[1]] $data_source_custom = {}, |
bastelfreak
added
enhancement
|
Hi @romdav00, thanks for the PR! Can you have a look at the used email address in the commits? It isn't associated with your github account. |
bastelfreak
reviewed
Jan 15, 2019
| String[1] $arch = $prometheus::real_arch, | ||
| String[1] $bin_dir = $prometheus::bin_dir, | ||
| Enum['custom', 'env', 'file'] $postgres_auth_method, | ||
| Hash[String[1],String[1]] $data_source_custom = {}, |
|
Thanks @romdav00. Can you take a look at the first commits in this branch? The used email address isn't associated with your github account. |
|
Hi @bastelfreak is it ok for you ? |
|
ah sorry, this PR slipped through. Thanks for pinging! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-prometheus
that referenced
this pull request
Aug 28, 2019
Add custom datasource possibilities for postgres_exporter
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Add custom datasource possibilities for postgres_exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @bastelfreak , it seems better now :-)