Extend puppet type check for install_method #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not align the whitespaces here because that just creates a huge huge diff without any benefit. |
until we find a better waytto make unaligned puppet code more readable, we should do alignment fixes in a separate commit |
|
okay, will do |
|
instead of realigning everything I moved the enum into a custom type. benefit: we can now update the enum at a single place to adjust it for every of our exporters \o/ |
previously we had a case statement that checked for 3 values in a string. We now uplift those 3 values into an enum to make validation better and easier to test.
igalic
previously requested changes
Sep 26, 2020
igalic
approved these changes
Sep 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously we had a case statement that checked for 3 values in a
string. We now uplift those 3 values into an enum to make validation
better and easier to test.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues