Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arch Linux Prometheus Server installation #684

Merged
merged 1 commit into from Aug 15, 2023
Merged

Fix Arch Linux Prometheus Server installation #684

merged 1 commit into from Aug 15, 2023

Conversation

bastelfreak
Copy link
Member

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

@bastelfreak bastelfreak added the bug Something isn't working label Aug 12, 2023
@bastelfreak bastelfreak self-assigned this Aug 12, 2023
Copy link
Contributor

@zilchms zilchms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}),
notify => $notify,
}
if versioncmp($facts['puppetversion'],'6.1.0') < 0 {
Copy link
Contributor

@zilchms zilchms Aug 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should maybe get rid of that, we are already not supporting puppet 5 anymore.
but that is a task for another issue/PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in #689

@bastelfreak bastelfreak merged commit 8518cd2 into master Aug 15, 2023
28 of 29 checks passed
@bastelfreak bastelfreak deleted the arch branch August 15, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants