Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongodb_exporter: make service name and binary path configureable #699

Merged

Conversation

ansgarwiechers
Copy link

Pull Request (PR) description

Set the parameter $service_name as the name for the MongoDB exporter daemon resource and add a parameter to allow overriding the name of the service binary.

This Pull Request (PR) fixes the following issues

Fixes #698

@bastelfreak
Copy link
Member

@ansgarwiechers thanks for the PR, please update the REFERENCE.md with bundle exec rake strings:generate:reference

@ansgarwiechers
Copy link
Author

So, checks for the updated PR failed again with errors that don't seem to have anything to do with the proposed change. What am I supposed to do now? @bastelfreak

@bastelfreak bastelfreak reopened this Jan 11, 2024
@bastelfreak
Copy link
Member

the registry from where we pull the CentOS images has some random timeouts. I restarted the jobs.

@bastelfreak bastelfreak changed the title Mongodb exporter name overrides mongodb_exporter: make service name and binary path configureable Jan 11, 2024
@bastelfreak bastelfreak added the enhancement New feature or request label Jan 11, 2024
@bastelfreak bastelfreak merged commit a158dee into voxpupuli:master Jan 11, 2024
55 of 61 checks passed
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this pull request Mar 11, 2024
…_name_overrides

mongodb_exporter: make service name and binary path configureable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mongodb_exporter doesn't allow overriding service and binary name
2 participants