Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup architecture selection, dont fail on unknown architecture #702

Merged
merged 2 commits into from Nov 9, 2023

Conversation

bastelfreak
Copy link
Member

prometheus exporters are built for so many architectures, chances are high that a platform we're not aware of works out of the box. We should not block this.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

prometheus exporters are built for so many architectures, chances are
high that a platform we're not aware of works out of the box. We
should not block this.
@bastelfreak bastelfreak added the enhancement New feature or request label Nov 8, 2023
Copy link
Member

@jhoblitt jhoblitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable.

@bastelfreak bastelfreak merged commit 2dc371b into voxpupuli:master Nov 9, 2023
28 of 29 checks passed
@bastelfreak bastelfreak deleted the arch2 branch November 9, 2023 13:12
@ni-jdyffort
Copy link

thanks, @bastelfreak! Unfortunately the arm version of the node_exporter does still not work:

$ file node_exporter
node_exporter: Mach-O 64-bit executable arm64
$ ./node_exporter -h
Killed: 9

(I also tried to run the [node_exporter-1.6.1.darwin-arm64.tar.gz](node_exporter-1.6.1.darwin-arm64.tar.gz directly with the same result).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants