add feature blackbox exporter #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Oct 19, 2017
templates/blackbox_exporter.yaml.erb
Outdated
| @@ -0,0 +1,4 @@ | |||
| <% require 'yaml' -%> | |||
| <% modules = scope.lookupvar('::prometheus::blackbox_exporter::modules') -%> | |||
There was a problem hiding this comment.
Just using @modules should be fine as well
bastelfreak
reviewed
Oct 19, 2017
manifests/blackbox_exporter.pp
Outdated
| # preferred_ip_protocol: ip4 | ||
| class prometheus::blackbox_exporter ( | ||
| Hash $modules = {}, | ||
| $arch = $::prometheus::params::arch, |
There was a problem hiding this comment.
please add datatypes to all of those params. An example is https://github.com/voxpupuli/puppet-prometheus/pull/68/files
|
Hi @bramblek1, thanks for the PR.
|
bramblek1
force-pushed
the
blackbox_exporter
branch
from
f27511c
to
0ae25b1
Compare
|
@bastelfreak please see changes to simplify template of 'modules' variable, all params with puppet4 types , commits squashed. |
|
Thanks! |
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
add feature blackbox exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a wrapper around prometheus::daemon for the blackbox exporter, following the pattern of other exporters.