Tests for prometheus::daemon

[sathieu]

No description provided.

[wyardley]

To me, having the entire body of both init scripts seems a bit like overkill, maybe?

[TheMeier]

whats the point of checking the complete content of the init scripts/unit file anyway?

[wyardley]

Yeah, that's what I mean.

[sathieu]

the point is that it is hard to ensure correct file syntax with all those new lines and backslash. But your are the reviewer, tell me what you want.

[TheMeier]

@sathieu i don't see how this check helps. if you change the files shipped in the module you need to change the files shipped in the fixtures. so basically you are duplicating content without any benefit added

[sathieu]

I generally agree, but this kind of rspec helped for https://github.com/voxpupuli/puppet-prometheus/pull/48/files (by ensuring that those <%= @daemon_flags.join(" \\\n ") %> or like were correct)

[TheMeier]

how about testing it this way

          if ['debian-7-x86_64'].include?(os)
            # init_style = 'debian'

            it {
              is_expected.to contain_file('/etc/init.d/smurf_exporter').with(
                'mode'    => '0555',
                'owner'   => 'root',
                'group'   => 'root',
              )
              should contain_file('/etc/init.d/smurf_exporter').with_content(/DAEMON_ARGS=''\n/)
            }

also prometheus::daemon doesn't actually set $daemon_flags so the join in this context always evaluates to ''

[wyardley]

should this be :title or :params and then setting :title in params?

[sathieu]

this is usually :title

[sathieu]

Here is the updated PR. No more using fixtures.

[wyardley]

Looks pretty good to me.