Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing openssl package #5

Merged
merged 1 commit into from Mar 28, 2014
Merged

Conversation

andyleejordan
Copy link
Contributor

Again, Prosody automatically includes openssl when installed.

So we shouldn't require it, apt does it for us. Package requirements in Puppet are really iffy, especially for packages that are shared dependencies (such as this). So long as apt pulls it in for us, let's not step on other modules.

If we do have to have it, use ensure_packages([package]).

Again, Prosody automatically includes openssl when installed.
@fpletz
Copy link
Contributor

fpletz commented Mar 28, 2014

Yup, thanks! 👍 This was actually some cruft from the upstream module. There are some more cleanups pending.

fpletz added a commit that referenced this pull request Mar 28, 2014
Removing openssl package
@fpletz fpletz merged commit a99da74 into voxpupuli:master Mar 28, 2014
@andyleejordan
Copy link
Contributor Author

For sure, I've been meaning to fork and update that upstream for a long time now. Glad to do it together.

@andyleejordan andyleejordan deleted the openssl branch March 28, 2014 23:00
@fpletz
Copy link
Contributor

fpletz commented Mar 28, 2014

Awesome! We were also thinking about forking for a long time. Let's do this!

@andyleejordan
Copy link
Contributor Author

Puppetlab's apt module makes adding repositories so nice. Granted, I currently manage repos/PPAs separately from modules (feel that it's cleaner). But adding the repository conditionally would be fine.

@andyleejordan
Copy link
Contributor Author

Just an update: all the updates I made work perfectly fine with the latest version (0.9.3-1~precise) of prosody as well.

@andyleejordan
Copy link
Contributor Author

@fpletz Also, you can go to settings and check "issues" to allow issues on forks now, which would be great for further development :)

@fpletz
Copy link
Contributor

fpletz commented Mar 28, 2014

Thanks for the report and the hint with the issues, just enabled them. Feel free to open tickets as you please. :) Need to go to sleep now, though, little bit drunk… 🍻

@andyleejordan
Copy link
Contributor Author

Sounds good! Thanks man. Have a good night, it is quite late in Germany right now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants