Introduce manage_mysql_client boolean to toggle whether or not to include mysql::client
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
requested changes
May 25, 2020
manifests/init.pp
Outdated
| @@ -170,6 +174,7 @@ | |||
| String $datadir = $proxysql::params::datadir, | |||
| Stdlib::Filemode $datadir_mode = $proxysql::params::datadir_mode, | |||
| Boolean $manage_selinux = true, | |||
| Boolean $manage_mysql_client = $proxysql::params::manage_mysql_client, | |||
There was a problem hiding this comment.
Could you just set the default true directly here and not use params.pp?
There was a problem hiding this comment.
(Which reminds me, I should really finish #127)
There was a problem hiding this comment.
Done. I was unsure whether to follow the pattern like $manage_selinux or $manage_mycnf_file.
alexjfisher
changed the title
manage_mysql_client boolean to toggle whether or not to include mysql::client
alexjfisher
approved these changes
May 26, 2020
|
@walkleyn Thanks! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-proxysql
that referenced
this pull request
Aug 22, 2023
…nclude mysql::client (voxpupuli#149)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description