Set custom vhost parameters. for example Basic Auth

[c33s]

currently it is not possible to add custom parameters to the vhost created for puppetboard.
to configure a simple Auth Basic the whole vhost has to be created by oneself.

with this PR it is possible to pipe all ::apache::vhost parameters through ::puppetboard::apache::vhost with $custom_apache_parameters

puppetboard::apache::vhost::vhost_name: "%{facts.networking.fqdn}"
puppetboard::apache::vhost::port:       443
puppetboard::apache::vhost::ssl:        true
puppetboard::apache::vhost::ssl_cert:   /etc/ssl/localcerts/xxx.crt
puppetboard::apache::vhost::ssl_key:    /etc/ssl/private/xxx.key
puppetboard::apache::vhost::custom_apache_parameters:
  directories:
    -
      provider: Directory
      path:  '/srv/puppetboard/puppetboard'
      custom_fragment: |
        AuthType Basic
        AuthName "Restricted Files"
        AuthBasicProvider file
        AuthUserFile "/etc/apache2/htpasswd"
        Require user admin
        Options Indexes FollowSymLinks MultiViews
        AllowOverride None

[ekohl]

Since it has a default, maybe this should just be Hash?

[c33s]

@ekohl i can change this if you want

[vinzent]

@ekohl why using {} instead of undef ? When using {} then every optional string would IMHO need '' instead of undef to be consistent. But then the parameters aren't Optional anymore because IMHO the empty string or the empty hash is already a value.

[crayfishx]

@vinzent because it gets used in a * => $custom_apache_parameters notation - you can't give undef as an argument to * so this would cause compilation failure - defaulting to {} is a lot cleaner than having to wrap things in conditionals... I do agree however that the use of Optional is not needed

[v4ld3r5]

Hi,
Would like to know if you do expect to merge this feature soon.
We're linking Puppetboard against an Active Directory and the current LDAP capability provided by the module isn't sufficient. I'm thinking on just setting puppetboard::apache::vhost::enable_ldap_auth: false, and instead feed the parameters through this new puppetboard::apache::vhost::custom_apache_parameters

Best regards,

[bastelfreak]

Hi @c33s, thanks for the PR!