Fix Apache configuration fragment directory on Debian

[mattock]

Debian has placed Apache configuration fragments into /etc/apache2/conf-enabled
since Debian 8, so /etc/apache2/conf.d is doomed to fail.

[wyardley]

Probably still requires the old path on other versions of Debian? So maybe wrap in another conditional with versioncmp()?

This one probably needs unit tests for the various scenarios.

Also, please use a commit email tied to your GitHub account.

[wyardley]

To be fair, metadata only claims support for Debian 8 currently.

[mattock]

@wyardley is there a particular reason why the email has to be the same as my GitHub registration email? I mean, the original author of this PR could be anyone and I could just be relaying a patch on his/her behalf. I generally set the author email based on who owns the copyrights to the work (me or an employer/client of mine). Let me know how you want to proceed with this.

[wyardley]

Vox just likes for the commit email to be tied with the submitter’s account so that the GitHub account shows up.

If you’d like someone else to have the attribution, that should be fine as long as their commit email is tied to a GH account

[mattock]

@wyardley yeah no problem, I can change the commit email. What about the unit tests you spoke about?

[wyardley]

So in the tests in https://github.com/voxpupuli/puppet-puppetboard/blob/master/spec/classes/puppetboard_spec.rb we should add some tests for the different cases in that conditional (even tho there’s no test coverage of it now). If you need help with what to test or how, #voxpupuli on IRC or Puppet Community slack or #testing on the latter may be able to help.